improve error message on invalid formatting of shell options #6680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wihobbs
force-pushed
the
issue-6678
branch
2 times, most recently
from
abc368f to
a953f13
Compare
Problem: There is no test that ensures that `flux alloc -o foo -o foo.bar=hi` returns an error message that is useful to an end user. Add such a test.
Problem: When submitting a job through the command line, a shell option `-o KEY[=VAL]` is not required to have a value. If one is not provided, then `attributes.system.shell.KEY` is set to 1. If a user later provides a sub-key of this shell option, such as `-o KEY.foo=bar`, the error message returned by Python is not particularly helpful. Wrap `set_treedict()` in a try/except where user input might provide an invalid key and raise a useful error message. Fixes flux-framework#6678
|
Just a minor point for next time. Not required, but we tend to try to keep the testsuite passing for each commit (sometimes helps with |
|
Oh, that makes sense. I was trying to show that I did test-driven-development ;) |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6680 +/- ##
==========================================
+ Coverage 83.85% 83.87% +0.01%
==========================================
Files 534 534
Lines 88931 88937 +6
==========================================
+ Hits 74577 74593 +16
+ Misses 14354 14344 -10
|
Yeah, that makes sense too (and I usually write the tests first as well) :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: When submitting a job through the command line, a shell option
-o KEY[=VAL]is not required to have a value. If one is not provided, thenattributes.system.shell.KEYis set to 1. If a user later provides a sub-key of this shell option, such as-o KEY.foo=bar, the error message returned by Python is not particularly helpful.Wrap
set_treedict()in a try/except where user input might provide an invalid key and raise a useful error message.Fixes #6678